determined
determined copied to clipboard
chore: upgrade protoc used in CI
Description
protoc was upgraded a while back and the new version is not compatible with the old.
make -C proto check
started fails locally when using the new version. This updates CI to use a newer version (24)
https://github.com/protocolbuffers/protobuf/releases
Test Plan
Commentary (optional)
Checklist
- [ ] Changes have been manually QA'd
- [ ] User-facing API changes need the "User-facing API Change" label.
- [ ] Release notes should be added as a separate file under
docs/release-notes/
. See Release Note for details. - [ ] Licenses should be included for new code which was copied and/or modified from any external code.
Ticket
Deploy Preview for determined-ui ready!
Name | Link |
---|---|
Latest commit | aaae2e147ca49434c5641919e71c1f7b4fb4e555 |
Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/6627c0d15df456000889fb12 |
Deploy Preview | https://deploy-preview-7935--determined-ui.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Will this require everyone to upgrade their local version?
Will this require everyone to upgrade their local version?
yes. We had a talk about this in the backend team around when it's okay to require dependency upgrades and the consensus was that as long as it's communicated we're good with it and we didn't go into more details. What do you think
I want to update https://github.com/determined-ai/determined/blob/ed7a283fccbdf56f8156686fc224183298c29e40/CONTRIBUTING.md#L58 but I haven't been able to pin down which specific version introduces the material change.
@varlogtim had set a cutoff here at >v22 so maybe we could expand it to that but since we're testing 24.3 with the ci and it's been out for a while let's just go for that? https://github.com/protocolbuffers/protobuf/releases/tag/v24.3
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 44.70%. Comparing base (
9f6bbc9
) to head (aaae2e1
).
Additional details and impacted files
@@ Coverage Diff @@
## main #7935 +/- ##
=======================================
Coverage 44.70% 44.70%
=======================================
Files 1270 1270
Lines 155132 155132
Branches 2437 2437
=======================================
+ Hits 69351 69352 +1
+ Misses 85545 85544 -1
Partials 236 236
Flag | Coverage Δ | |
---|---|---|
backend | 41.57% <ø> (+<0.01%) |
:arrow_up: |
harness | 64.31% <ø> (ø) |
|
web | 35.23% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
makes sense to wait for the unforking to happen before landing this