determined
determined copied to clipboard
chore(build): Bumps up Makefile required go version to 1.21
Versioning Fix
Description
Per determined/master/go.mod
the version said module expects is 1.21
but Makefile still required 1.20
in its pre-build checks.
Test Plan
- Run
make all
withgo1.21.x
- Check if it successfully builds
Checklist
- [ ] Changes have been manually QA'd
- [ ] User-facing API changes need the "User-facing API Change" label.
- [ ] Release notes should be added as a separate file under
docs/release-notes/
. See Release Note for details. - [ ] Licenses should be included for new code which was copied and/or modified from any external code.
Ticket
DET-9791
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @keramosg on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.
After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check
to rerun the check.
Deploy Preview for determined-ui ready!
Name | Link |
---|---|
Latest commit | 645cae26dfb59f4555c0952a11b747652ed7446d |
Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/64f0d7c50135380008470861 |
Deploy Preview | https://deploy-preview-7748--determined-ui.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @keramosg on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.
After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check
to rerun the check.
didnt notice this PR, but the same fix is merged as #7751