determined
determined copied to clipboard
determined-ai
fix: query setting now reflects on settings drawer option
Description
Ticket: WEB-1607
Bug scenario: set any feature via query parameters.
- it changes the UI
- setting drawer doesn't reflect the current UI state
- you can't manually change the setting through the drawer
Test Plan
- set any feature via query parameters
- check UI
- open settings drawer (it should be on-par with query parameters)
- change the setting manually via drawer
- it should reflect in the UI and query parameter
Commentary (optional)
Checklist
- [ ] Changes have been manually QA'd
- [ ] User-facing API changes need the "User-facing API Change" label.
- [ ] Release notes should be added as a separate file under
docs/release-notes/. See Release Note for details. - [ ] Licenses should be included for new code which was copied and/or modified from any external code.
Ticket
Deploy Preview for determined-ui ready!
| Name | Link |
|---|---|
| Latest commit | c90c3c02947119de7fb38f5b91c65231b865422a |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/64e523b4ab8f1600083409c9 |
| Deploy Preview | https://deploy-preview-7705--determined-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
As Guangqing said in the ticket, I cannot reproduce it either in main branch.
The linked ticket has nothing to do with query parameters, it's about the default feature state.
the default feature state follows the constant that we've created, which works just fine, the fix that I have proposed here is an approximate one to what @aciborowska had (which I came upon by accident while trying alternatives to reproduce the actual bug), which I confirmed with her previously since the actual scenario description couldn't be reproduced.
should we open a specific ticket for it, or just change the current one? @ClaireNeveu
@thiagodallacqua-hpe Unless something has changed, the default feature state is not reflected on the settings page, which is the bug here. If that is no longer present then you should close the ticket. If you've found another issue please open a new ticket.
