determined icon indicating copy to clipboard operation
determined copied to clipboard

fix: Table reordering fixed

Open thiagodallacqua-hpe opened this issue 2 years ago • 2 comments

Description

After the merge of the #5056 the table reordering had an issue on the first render where the elements didn't have the widthData properly set (it was relying on a useEffect hook that was removed).

Test Plan

Go to /det/projects/ and "play" with the table 😁

Commentary (optional)

demo:

https://user-images.githubusercontent.com/104855841/193300868-2f1d770d-9995-4af2-8977-cbb27dd4beff.mp4

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.
  • [ ] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

thiagodallacqua-hpe avatar Sep 30 '22 15:09 thiagodallacqua-hpe

Deploy Preview for storybook-det ready!

Name Link
Latest commit 40ce4c07e72fca72e91628f2492692cd555c3eee
Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/633c55bd8060550008fafc89
Deploy Preview https://deploy-preview-5159--storybook-det.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 30 '22 15:09 netlify[bot]

Deploy Preview for determined-ui ready!

Name Link
Latest commit 40ce4c07e72fca72e91628f2492692cd555c3eee
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/633c55bde242700009429fc5
Deploy Preview https://deploy-preview-5159--determined-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 30 '22 15:09 netlify[bot]

I don't think that it came from one of my changes, but there you go:

https://user-images.githubusercontent.com/104855841/193598977-55f5cb17-a6b5-4d85-9b64-e1acef702976.mp4

thiagodallacqua-hpe avatar Oct 03 '22 14:10 thiagodallacqua-hpe

The default width is broken. Some column widths are too short, some are too long

https://user-images.githubusercontent.com/109113616/193634718-656267e7-7980-404c-a5f8-3e80be8c0d07.mov

keita-determined avatar Oct 03 '22 16:10 keita-determined

The previous issue is fixed. However, I see another issue. It works on latest-master website, but not in this PR.

I cannot resize the column width with few columns. I think it's the last bug so far (hopefully :))

https://user-images.githubusercontent.com/109113616/193644407-3f54d8e7-6c24-468c-875a-104c378d0418.mov

keita-determined avatar Oct 03 '22 17:10 keita-determined