determined
determined copied to clipboard
feat: agent user group settings per workspace [DET-8472, DET-7547]
Description
- Added an ability to set the Unix user and group on the agent that the task runs as on workspace level. When set, it will take precedence over user's own agent user and group setting.
- Currently we only have experiments compartmentalized within the workspace, which means only experiments and checkpoint gc tasks will employ this mechanism.
- Intended use case is to set
gidandgroupname(and potentiallyuidandusername) on a workspace level to ensure shared and uniform access toshared_fsstorage for all users within the workspace. - CLI support:
det workspace (create|edit) ... [--agent-uid AGENT_UID] [--agent-gid AGENT_GID] [--agent-user AGENT_USER] [--agent-group AGENT_GROUP]
Test Plan
See e2e_test as an example: submit an experiment to a workspace which runs id to check its uid/gid settings.
Commentary (optional)
TODO:
- RBAC implementations for CanSetWorkspaceAUG.
Checklist
- [ ] Changes have been manually QA'd
- [ ] User-facing API changes need the "User-facing API Change" label.
- [ ] Release notes should be added as a separate file under
docs/release-notes/. See Release Note for details. - [ ] Licenses should be included for new code which was copied and/or modified from any external code.
- [ ] If modifying
/webui/react/src/shared/verifymake -C webui/react test-sharedpasses.
Deploy Preview for storybook-det canceled.
| Name | Link |
|---|---|
| Latest commit | e74f30df56cd44d99232154e9f86ab5ad21449cb |
| Latest deploy log | https://app.netlify.com/sites/storybook-det/deploys/633b302227f1860008830635 |
Deploy Preview for determined-ui canceled.
| Name | Link |
|---|---|
| Latest commit | e74f30df56cd44d99232154e9f86ab5ad21449cb |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/633b3022a7a81200089a94b6 |
I don't know enough about the agent user group effects on the cluster and CLI and experiments, but the changes to Projects and Workspaces LGTM