determined icon indicating copy to clipboard operation
determined copied to clipboard

Published 20 hours ago • verified publisher icon determined-ai

feat: add echo authentication by default

Open eecsliu opened this issue 2 years ago • 3 comments

Description

Reapplying the older echo-auth PR but with slightly changed endpoints.

Test Plan

Commentary (optional)

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.
  • [ ] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

eecsliu avatar Sep 12 '22 18:09 eecsliu

Deploy Preview for determined-ui canceled.

Name Link
Latest commit 4889b2f671466835a1baf836bf9f1952fa9a1de0
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/633df1afb929f3000853708c

netlify[bot] avatar Sep 12 '22 18:09 netlify[bot]

Deploy Preview for storybook-det canceled.

Name Link
Latest commit 4889b2f671466835a1baf836bf9f1952fa9a1de0
Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/633df1af8955a5000884b7cd

netlify[bot] avatar Sep 12 '22 18:09 netlify[bot]

@dzhu some of the endpoints has been removed and replaced with just /api/v1/.* - it seems like grpc does its own authentication and we therefore don't need to check in echo?

eecsliu avatar Sep 12 '22 18:09 eecsliu