determined icon indicating copy to clipboard operation
determined copied to clipboard

feat: Trials Comparison Frontend

Open trentwatt opened this issue 2 years ago • 2 comments

Description

follow on to #4543. will rebase this after getting that merged.

Test Plan

Commentary (optional)

Checklist

  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.
  • [ ] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

trentwatt avatar Aug 18 '22 18:08 trentwatt

Deploy Preview for determined-ui ready!

Name Link
Latest commit 64803b8f5dcdc8f6cbfc0a4faf16526f2504d6dd
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/634fdcc15d07010008ffe283
Deploy Preview https://deploy-preview-4820--determined-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 18 '22 18:08 netlify[bot]

Deploy Preview for storybook-det ready!

Name Link
Latest commit 64803b8f5dcdc8f6cbfc0a4faf16526f2504d6dd
Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/634fdcc1b045b800088f0213
Deploy Preview https://deploy-preview-4820--storybook-det.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 25 '22 22:08 netlify[bot]

Can you add a feature switch and show the tab when the feature switch is enabled?

ClaireNeveu avatar Oct 04 '22 14:10 ClaireNeveu

Can you add a feature switch and show the tab when the feature switch is enabled?

ok done

trentwatt avatar Oct 06 '22 16:10 trentwatt

Tests (except for downstream test which is currently broken from stylelint PR) passed here with only trivial changes since.

trentwatt avatar Oct 19 '22 11:10 trentwatt