determined icon indicating copy to clipboard operation
determined copied to clipboard

fix: allow moving jobs to top without assuming the full job list [DET-8015]

Open hamidzr opened this issue 1 year ago • 2 comments

Description

issues:

  • move to top
  • move job to position number N

cause: computing how to move a job to an arbitrary position requires the full list of jobs. previously this was fine as the ui was always working with full list of jobs but we started breaking down the jobs and didn't see this issue.

Test Plan

  • TODO repro with release cluster

Commentary (optional)

watch out for https://github.com/determined-ai/determined/pull/4756 . the changes here are set in a way that allow that pr to go through without having to build additional endpoints for now

Checklist

  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.
  • [ ] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

hamidzr avatar Aug 11 '22 00:08 hamidzr

Deploy Preview for determined-ui ready!

Name Link
Latest commit e66a1205faac121b2d614899f3d5f0cef8ac4056
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/63054f0c049718000be46fd4
Deploy Preview https://deploy-preview-4766--determined-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 11 '22 00:08 netlify[bot]

Not sure if I had data set up correctly locally, but did encounter a master error when click Move to Top on Queued tab, then switch to Active tab.

Screen.Recording.2022-08-12.at.12.06.14.PM.mov

hmm this could certainly happen looking at the code https://github.com/hamidzr/determined/blob/c6579efc53a10c87cd558b2161f1cb1406838f67/master/internal/rm/agent_resource_manager.go#L603 but I'm not sure why or if it's directly related to the changes here 🤔

hamidzr avatar Aug 12 '22 18:08 hamidzr

Not sure if I had data set up correctly locally, but did encounter a master error when click Move to Top on Queued tab, then switch to Active tab.

Screen.Recording.2022-08-12.at.12.06.14.PM.mov

to figure out if the two are related: did the move to top the action take effect as you expected? can you reproduce the error on master as well?

update: from your screenshot the move to top works fine and it seems that the job gets moved as expected. do I see that right?

hamidzr avatar Aug 16 '22 18:08 hamidzr

I was able to reproduce the bug on master https://determinedai.atlassian.net/browse/DET-8214

update: I pushed the fix for that issue in this branch as well to help with testing

hamidzr avatar Aug 23 '22 20:08 hamidzr

the failing test is a known issue.

hamidzr avatar Aug 23 '22 22:08 hamidzr