determined icon indicating copy to clipboard operation
determined copied to clipboard

fix: use correct experiment list offset when deleting an experiment [DET-7880]

Open julian-determined-ai opened this issue 2 years ago • 1 comments

Description

fix: use correct experiment list offset when deleting an experiment DET-7880

Currently, the table offset is not correctly updated when an experiment is deleted. We want to re-calculate the correct offset if the current offset is greater than or equal to the total number of items in the table.

Test Plan

  1. Navigate to the experiments list and navigate to the last page of experiments.
  2. Delete or Archive all the experiments on the last page.
  3. After deleting the last experiment on the last page, the table to automatically show the previously second to last page.

Commentary (optional)

Checklist

  • [ ] User-facing API changes need the "User-facing API Change" label.
  • [ ] Release notes should be added as a separate file under docs/release-notes/. See Release Note for details.
  • [ ] Licenses should be included for new code which was copied and/or modified from any external code.
  • [ ] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

julian-determined-ai avatar Aug 10 '22 15:08 julian-determined-ai

Deploy Preview for determined-ui ready!

Name Link
Latest commit 04175fbdcadeb158e594178713a57085da935379
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/62f3cf81087fd40008021ce6
Deploy Preview https://deploy-preview-4754--determined-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 15:08 netlify[bot]