determined icon indicating copy to clipboard operation
determined copied to clipboard

feat: Async deleting workspaces and projects (from CLI) [DET-7821]

Open mapmeld opened this issue 3 years ago • 1 comments

Description

  • Removed limits of CLI on deleting workspaces and projects
  • Deleting an empty project/workspace continues to work immediately (added new completed: true attribute to response)
  • Deleting used projects starts an async process to delete experiments (until one fails), then deletes the project
  • Deleting used workspace starts an async process to delete projects (until one fails) with the same project-deletion function, then deletes the workspace
  • Workspaces and projects have a 'state' property tracking DELETING / DELETE_FAILED. This is optionally visible in the WebUI

Future work: remove limits on WebUI, add notifications, etc.

Test Plan

Currently outputs go to the log

  • Create and delete a workspace without adding anything (WebUI and CLI)
  • Create a workspace, add empty projects, and delete the workspace (WebUI and CLI)
  • Create a workspaces, add projects, add experiments inside some of the projects (det e create sample/const.yaml sample/ --project_id 248)
  • Delete a project from the CLI (det p delete WorkspaceName ProjectName) and delete workspace (det w delete WorkspaceName)
  • If you have an experiment which has DELETE_FAILED status for some reason, det e move ExperimentID WorkspaceName ProjectName will make that workspace and project un-deletable.

Checklist

  • [x] User-facing API changes need the "User-facing API Change" label.
  • [x] Release notes should be added as a separate file under docs/release-notes/.
  • [x] Licenses should be included for new code which was copied and/or modified from any external code.
  • [x] If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

mapmeld avatar Jul 29 '22 17:07 mapmeld

Deploy Preview for determined-ui canceled.

Name Link
Latest commit a189e7b0f657d29811d33f84a9e453d72f91282d
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/62faba0715c13c000a44f46c

netlify[bot] avatar Jul 29 '22 17:07 netlify[bot]