determined icon indicating copy to clipboard operation
determined copied to clipboard

chore: add SDK functionality for SSO Improvements

Open ShreyaLnuHpe opened this issue 1 year ago • 2 comments

Ticket

DET-10456 DET-10406 DET-10402 DET-10399

Description

Test Plan

Checklist

  • [ ] Changes have been manually QA'd
  • [ ] New features have been approved by the corresponding PM
  • [ ] User-facing API changes have the "User-facing API Change" label
  • [ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
  • [ ] Licenses have been included for new code which was copied and/or modified from any external code

ShreyaLnuHpe avatar Oct 22 '24 18:10 ShreyaLnuHpe

Codecov Report

Attention: Patch coverage is 21.66667% with 94 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (34e4749) to head (8854901). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
harness/determined/cli/token.py 11.36% 39 Missing :warning:
harness/determined/common/experimental/token.py 32.65% 33 Missing :warning:
harness/determined/common/api/authentication.py 7.14% 13 Missing :warning:
...rness/determined/common/experimental/determined.py 30.76% 9 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (34e4749) and HEAD (8854901). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (34e4749) HEAD (8854901)
harness 16 5
web 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10096      +/-   ##
==========================================
- Coverage   54.39%   49.33%   -5.07%     
==========================================
  Files        1268     1227      -41     
  Lines      159317   157143    -2174     
  Branches     3631     3631              
==========================================
- Hits        86668    77521    -9147     
- Misses      72515    79488    +6973     
  Partials      134      134              
Flag Coverage Δ
harness 44.05% <21.66%> (-28.50%) :arrow_down:
web 53.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rness/determined/common/experimental/determined.py 26.66% <30.76%> (-20.04%) :arrow_down:
harness/determined/common/api/authentication.py 15.93% <7.14%> (-71.32%) :arrow_down:
harness/determined/common/experimental/token.py 32.65% <32.65%> (ø)
harness/determined/cli/token.py 16.07% <11.36%> (-0.10%) :arrow_down:

... and 195 files with indirect coverage changes

codecov[bot] avatar Oct 22 '24 18:10 codecov[bot]

Deploy Preview for determined-ui ready!

Name Link
Latest commit 8854901899e6388a75ea0f386822e97290d1ec82
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6717ecf163efe6000824d3c2
Deploy Preview https://deploy-preview-10096--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 22 '24 18:10 netlify[bot]