determined
determined copied to clipboard
fix: support multi-type columns in flat run table
Ticket
Description
- Support multi-type columns in flat run table in case there are the same column names with different types.
Test Plan
- Add columns from column picker, and columns show the right data even if there are the same column name like metadata.
- Column header shows its types.
- some special columns does not show types since types are unknown
Checklist
- [x] Changes have been manually QA'd
- [ ] New features have been approved by the corresponding PM
- [ ] User-facing API changes have the "User-facing API Change" label
- [ ] Release notes have been added as a separate file under
docs/release-notes/See Release Note for details. - [ ] Licenses have been included for new code which was copied and/or modified from any external code
Deploy Preview for determined-ui ready!
| Name | Link |
|---|---|
| Latest commit | 4e3c1c6e6dbe3ef89d009575a8fb48d8ecec0b2e |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/6717fcfded911f0008f8fd03 |
| Deploy Preview | https://deploy-preview-10066--determined-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Attention: Patch coverage is 24.00000% with 38 lines in your changes missing coverage. Please review.
Project coverage is 50.46%. Comparing base (
c6c476c) to head (4e3c1c6). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10066 +/- ##
==========================================
- Coverage 54.45% 50.46% -4.00%
==========================================
Files 1267 957 -310
Lines 159440 130680 -28760
Branches 3633 3633
==========================================
- Hits 86820 65943 -20877
+ Misses 72486 64603 -7883
Partials 134 134
| Flag | Coverage Δ | |
|---|---|---|
| harness | ? |
|
| web | 53.93% <24.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| webui/react/src/components/Searches/columns.ts | 51.78% <83.33%> (-0.11%) |
:arrow_down: |
| webui/react/src/utils/flatRun.ts | 97.61% <75.00%> (-1.54%) |
:arrow_down: |
| webui/react/src/pages/F_ExpList/expListColumns.ts | 20.98% <0.00%> (+0.04%) |
:arrow_up: |
| webui/react/src/pages/FlatRuns/columns.ts | 18.29% <0.00%> (-0.20%) |
:arrow_down: |
| webui/react/src/pages/FlatRuns/FlatRuns.tsx | 11.12% <5.55%> (-0.01%) |
:arrow_down: |