chore: Remove `max_length` from WebUI
Ticket
Description
Part of searcher context removal project.
Remove max_length for searchers in WebUI
Test Plan
Continue/Fork/HPSearch work as expected with the right backend. Tests passed.
Checklist
- [ ] Changes have been manually QA'd
- [ ] New features have been approved by the corresponding PM
- [ ] User-facing API changes have the "User-facing API Change" label
- [ ] Release notes have been added as a separate file under
docs/release-notes/See Release Note for details. - [ ] Licenses have been included for new code which was copied and/or modified from any external code
Deploy Preview for determined-ui ready!
| Name | Link |
|---|---|
| Latest commit | 636289de06df749c836cfb09411ed1a7222642cf |
| Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/6706ea3195ea9d00083044f1 |
| Deploy Preview | https://deploy-preview-10033--determined-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
Project coverage is 50.55%. Comparing base (
c27054d) to head (765da1c). Report is 107 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10033 +/- ##
==========================================
- Coverage 54.60% 50.55% -4.05%
==========================================
Files 1259 949 -310
Lines 157366 128485 -28881
Branches 3617 3595 -22
==========================================
- Hits 85931 64958 -20973
+ Misses 71302 63394 -7908
Partials 133 133
| Flag | Coverage Δ | |
|---|---|---|
| harness | ? |
|
| web | 54.33% <75.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...rc/components/CompareHyperparameters.test.mock.tsx | 100.00% <ø> (ø) |
|
| .../react/src/components/ComparisonView.test.mock.tsx | 99.30% <ø> (-0.01%) |
:arrow_down: |
| ...react/src/components/HyperparameterSearchModal.tsx | 90.46% <ø> (-0.07%) |
:arrow_down: |
| ...s/ExperimentDetails/ExperimentDetails.test.mock.ts | 100.00% <ø> (ø) |
|
| webui/react/src/types.ts | 99.70% <ø> (-0.01%) |
:arrow_down: |
| webui/react/src/utils/experiment.ts | 90.79% <ø> (+0.86%) |
:arrow_up: |
| webui/react/src/utils/tests/generateTestData.ts | 91.95% <ø> (-0.05%) |
:arrow_down: |
| ...bui/react/src/components/ExperimentCreateModal.tsx | 86.50% <75.00%> (+4.92%) |
:arrow_up: |
| ...i/react/src/components/ExperimentContinueModal.tsx | 68.40% <81.81%> (+4.82%) |
:arrow_up: |
| ...ages/ExperimentDetails/ExperimentDetailsHeader.tsx | 74.32% <60.00%> (ø) |
Docsite preview being generated for this PR. You can (eventually) find the generated docsite here.
Docsite preview being generated for this PR. You can (eventually) find the generated docsite here.
@gt2345 Can this be closed? I'm guessing it got incorporated into a larger PR.