Dr. Denis comments

Results 308 comments of


                                            Dr. Denis

Create descriptions for robots from examples

@olivier-stasse here is something I would need help with, so if you have some time I would be very thankful :) ### Current state * in #4 there is initial...

Create descriptions for robots from examples

Oh, I wrote that confusing... I meant not to parse xacro file manually, but to convert it automatically in launch file into URDF file. this didn‘t work for me with...

Create descriptions for robots from examples

Full list of examples: [source](https://github.com/ros-controls/roadmap/blob/master/design_drafts/components_architecture_and_urdf_examples.md) - [x] Industrial Robots with only one interface - #37 and ros-controls/ros2_control#140 - [x] Industrial Robots with multiple interfaces (can not be written at the...

Example executables from README are missing

@AndyZe sorry, the README was in the old state. I updated it just now...

Create demo for example 3 : Industrial Robots with integrated sensor

Please consider also ros-controls/roadmap#32

Issues with demos

@blakermchale thanks for pointing this out. I'll look at this later today.

Making rrbot position only working on Gazebo

I will merge #53 his week so the joint_trajectory_controller is there.

effort_controllers/joint_position_controller from ROS1

@tonylitianyu you wanted to contribute to this. Is this still the case?

Cleanup tests for controllers to not call `on_configure` if `on_init` fails

It's actually inverse and expected behavior. Those will be resolved soon, when we merge all Parameters stuff.

position_controllers/GripperActionController is in gripper_controllers package?

I agree with you. We missed this when porting to ROS2. @bmagyar, @Karsten1987 what do you think?