search-by-image icon indicating copy to clipboard operation
search-by-image copied to clipboard

Published 20 hours ago • verified publisher icon dessant

Add back icons in front of search mode options in the pop-up menu

Open mikelei8291 opened this issue 3 years ago • 8 comments

Is your feature request related to a problem? Please describe. Before the recent update, there were icons in front of each search mode options in the pop-up menu, as shown in this image from the README of the project: options with icons

However, these icons were removed after the recent update, as shown in this image: options with no icon

As a long time user of the extension, it was very confusing when I tried to change options for the first time after updating to the new version, especially when you have also changed the name of some options. These icons are very intuitive and easy to understand at the first glance, and I wonder why you decided to remove them in the recent update.

Describe the solution you'd like Add these icons back please.

mikelei8291 avatar Oct 21 '21 05:10 mikelei8291

Yes please

neoOpus avatar Nov 19 '21 00:11 neoOpus

having the website icons as well in the right-click menu can be useful too

neoOpus avatar Dec 20 '21 10:12 neoOpus

@neoOpus The website favicons were already there in the context menu.

mikelei8291 avatar Dec 21 '21 01:12 mikelei8291

It doesn't seem so on my side

https://i.imgur.com/Rvz64LU.png

neoOpus avatar Dec 21 '21 01:12 neoOpus

@neoOpus Extension version 4.4.0 is showing favicons on Firefox 96.0b5, maybe it's a bug of Edge. You should open a new issue for this.

mikelei8291 avatar Dec 21 '21 01:12 mikelei8291

The API for adding icons to context menu items is only supported by Firefox.

dessant avatar Dec 21 '21 02:12 dessant

@dessant Thanks for the reply. Any thoughts on the original issue?

mikelei8291 avatar Dec 21 '21 02:12 mikelei8291

@mikelei8291, I'll look into adding an option for bringing back the icons.

dessant avatar Dec 30 '21 08:12 dessant

Here's a preview of the new extension popup with menu icons.

dessant avatar Apr 16 '23 07:04 dessant

it would be great to have the option to show the icons only on top as a toolbar (one less click)

neoOpus avatar Apr 16 '23 12:04 neoOpus

@neoOpus, that would be nice to have, though the UI needs to be redesigned for that feature because there is not enough horizontal space on mobile. You can subscribe to this related issue, they will probably be implemeneted together: https://github.com/dessant/search-by-image/issues/219

dessant avatar Apr 16 '23 13:04 dessant

Fixed in version 5.5.0, the update should arrive in the next few days.

dessant avatar May 31 '23 12:05 dessant

Thanks for addressing it. Excited for the update! 👍🎉

neoOpus avatar Jun 01 '23 03:06 neoOpus