thumb-key icon indicating copy to clipboard operation
thumb-key copied to clipboard

F-Droid build not reproducible

Open linsui opened this issue 2 years ago • 44 comments

diff.zip

Could you please take a look? Thanks!

linsui avatar Sep 10 '23 13:09 linsui

We've had this error before, but I've changed nothing about the signing. All I did was upgrade some dependencies. I'm sure it'll resolve itself like before: in a few releases, f-droid will start working again, and I'll still have changed nothing about the signing config.

dessalines avatar Sep 10 '23 13:09 dessalines

It's not about the signing config. How do you build your apk?

linsui avatar Sep 10 '23 13:09 linsui

./gradlew assembleRelease

That also hasn't changed, and there's been working and broken f-droid builds before and after that.

dessalines avatar Sep 10 '23 20:09 dessalines

And again today, fyi https://gitlab.com/fdroid/fdroiddata/-/commit/c5375a76ae39f6f180c1ec15d2977b1138855e0f

difflog: thumb34.log

licaon-kter avatar Sep 21 '23 08:09 licaon-kter

What usually causes these?

dessalines avatar Sep 21 '23 13:09 dessalines

Different jdk versions, Android studio, or cache not cleaned. Which jdk do you use to build your apk?

linsui avatar Sep 21 '23 13:09 linsui

Uh oh, ./gradlew --version says I'm using:

JVM: 17.0.8.1 (Oracle Corporation 17.0.8.1+1)

Yet my java --version is:

openjdk 17.0.8.1 2023-08-24

Maybe these lines are incorrect? https://github.com/dessalines/thumb-key/blob/main/app/build.gradle#L54

dessalines avatar Sep 21 '23 14:09 dessalines

Maybe the oracle jdk produce different binaries. Those lines are correct.

linsui avatar Sep 21 '23 14:09 linsui

Okay, it looks like doing this is the only true way to figure out what java is being used in the build process.

I'll try setting my JAVA_HOME explicitly to my openjdk version for the next build, and ensuring that it uses it for the process. What a mess.

dessalines avatar Sep 21 '23 15:09 dessalines

fyi 2.1.1 not RB either https://gitlab.com/fdroid/fdroiddata/-/commit/2060e300fb57f492478bd3fe94c309a03b63b71b

Difflog is the same as linked above :(

licaon-kter avatar Oct 03 '23 10:10 licaon-kter

Not sure what I should do to fix it. This one was built with openjdk 17 .

dessalines avatar Oct 04 '23 12:10 dessalines

36 was ok :shrug: https://gitlab.com/fdroid/fdroiddata/-/jobs/5227631297#L635

licaon-kter avatar Oct 05 '23 07:10 licaon-kter

Hmm, insteresting...

linsui avatar Oct 05 '23 07:10 linsui

I upgraded to gradle 8.3 for that one, not sure what else I did to make that one work.

dessalines avatar Oct 05 '23 11:10 dessalines

@dessalines not only gradle, also these https://github.com/dessalines/thumb-key/commit/c19472211797c14f2aa2a150ec70734d8a551cc2

licaon-kter avatar Oct 05 '23 14:10 licaon-kter

again https://gitlab.com/fdroid/fdroiddata/-/jobs/5294738530#L1087 :(

fyi https://gitlab.com/fdroid/fdroiddata/-/commit/f10fc71a2df359d433fceb7979e3f6b75f2e27ce

licaon-kter avatar Oct 16 '23 14:10 licaon-kter

2.5.2 is reproducible.

linsui avatar Nov 03 '23 07:11 linsui

Might have been the upgrade to gradle 8.4 , but I have no idea lol. I apologize for these.

dessalines avatar Nov 03 '23 13:11 dessalines

reopen https://monitor.f-droid.org/builds/log/com.dessalines.thumbkey/43#site-footer

will rebuild locally to see the diff

licaon-kter avatar Nov 10 '23 12:11 licaon-kter

Difflog: thumb43.log

Local APK: com.dessalines.thumbkey_43.apk.ZIP (remove .ZIP)

licaon-kter avatar Nov 10 '23 13:11 licaon-kter

2.6.5 failed again. diff.zip

linsui avatar Jan 04 '24 06:01 linsui

No idea what causes these. This one is even stranger since I update zero gradle deps: https://github.com/dessalines/thumb-key/compare/2.6.4...2.6.5#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9

dessalines avatar Jan 04 '24 15:01 dessalines

https://gitlab.com/fdroid/fdroiddata/-/jobs/5964721139#L502 fyi

licaon-kter avatar Jan 19 '24 08:01 licaon-kter

at least it's a new error https://gitlab.com/fdroid/fdroiddata/-/jobs/6133897492#L566

licaon-kter avatar Feb 09 '24 11:02 licaon-kter

https://gitlab.com/fdroid/fdroiddata/-/jobs/6145358484#L600

Only in /tmp/tmp2thsd9qi/tmp_binaries_com.dessalines.thumbkey_57.binary/content/assets: RELEASES.md

licaon-kter avatar Feb 12 '24 08:02 licaon-kter

It's generated with https://github.com/dessalines/thumb-key/blob/main/generate_changelog.sh.

linsui avatar Feb 12 '24 13:02 linsui

I spose I just need to make sure that file is added to git then. I'll try that for the next release.

dessalines avatar Feb 12 '24 14:02 dessalines

Why did 2.6.15 fail? I added the missing file for that one.

dessalines avatar Feb 14 '24 18:02 dessalines

difflog: thumb58.log

licaon-kter avatar Feb 16 '24 13:02 licaon-kter

I'm not sure how to read these, but it says that even things like ArrayList differ.

dessalines avatar Feb 16 '24 13:02 dessalines