atlas icon indicating copy to clipboard operation
atlas copied to clipboard

Published 20 hours ago • verified publisher icon dessa-oss

Removes 'nvidia' runtime parameter when Docker version is >= 19.03 (n…

Open bgreer101 opened this issue 4 years ago • 2 comments

With the release of Docker 19.03 there is no longer the need to install nvidia-docker2 to access GPU's. When atlas-server start -g is called, it appends the 'nvidia' runtime flag which no longer is required nor exists and causes the scheduler to fail to start. This patch only add's the runtime flag if gpu is requested, and docker is <= 19.03

bgreer101 avatar Jun 02 '20 21:06 bgreer101

Can confirm: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4585

mohammedri avatar Jun 03 '20 14:06 mohammedri

@bgreer101 thanks for the PR! The user acceptance test pipeline is 🔴 now, but a fix is on the way. Let's hold off on merge until then: https://jenkins.shehanigans.net/job/foundations-uat/

mohammedri avatar Jun 03 '20 14:06 mohammedri