Danny Martini comments

Results 96 comments of


                                            Danny Martini

fix: add support for proxy backends

> hey @despairblue thanks for adding the tests and cleaning up the implementation. :) I was going to look at the tests tomorrow! I appreciate it! > > Is there...

refactor(core): Introduce `@RegisteredEntity` decorator

@guillaumejacquart @ivov @netroy I was wondering if this would make sense: https://github.com/n8n-io/n8n/compare/introduce-registered-entity-decorator-alternative-1 TLDR: 1. The `BaseN8nModule` enforces modules to implement an `entities` function that returns all entities 2. The module...

build(core): Allow adding tests side by side with the code

> Let's do the same for `workflow` package? @ivov done

fix(core): Don't allow creating more projects than allowed by exploiting a race condition

@ivov could you check the LicenseState changes? Thanks ❤️

fix(core): Prefer triggers with run data during partial executions

> Hey, code looks good to me. I don't know the execution logic enough, but I was just wondering if this did not break some hypothetical other cases when we...

fix(core): Increment executionIndex in partial executions (no-changelog)

@mutdmour Would this achieve the same? I tested it manually and it works in the cases I tried and is less intrusive: https://github.com/n8n-io/n8n/compare/sug-48-alternative-1?expand=1

The expression evaluated to a falsy value: a.ok(to) (Working on version 1.80.5, not working on any higher version up to 1.86.0)

@lukas-sieber can you share the workflow with us? And if possible a video showing exactly what you do? With that we should be able to find what's wrong. Right now...

Danny Martini