frontend icon indicating copy to clipboard operation
frontend copied to clipboard

New Emoji Picker for Posts

Open metaspartan opened this issue 4 years ago • 4 comments

This adds in a new Emoji icon next to embeds and images for posting, which brings up a nice selector to select an emoji, it can go off system themes only (light or dark) but we could expand this eventually...Seems to work great on mobile as well, this uses unicode emojis so they fit right into your current message.

This does have a new dependency required npm install @joeattardi/emoji-button so you will need to do a fresh npm install of the frontend for this to work, otherwise should be good to go @lazynina @maebeam @diamondhands0

Preview: 0JtjRoQYEL

metaspartan avatar Jun 19 '21 23:06 metaspartan

@carsenk I suggested some changes that should apply the selected theme to the emoji picker. This is an example of what it looks like on legends theme with the suggested changes

image

lazynina avatar Jun 21 '21 03:06 lazynina

@carsenk I suggested some changes that should apply the selected theme to the emoji picker. This is an example of what it looks like on legends theme with the suggested changes

image

Pushed changes up, works across themes! 🚀🤘

metaspartan avatar Jun 21 '21 04:06 metaspartan

While this PR looks great, our package-lock.json file is currently frozen until we implement LavaMoat to protect against dependency tree compromises.

maebeam avatar Jun 21 '21 16:06 maebeam

While this PR looks great, our package-lock.json file is currently frozen until we implement LavaMoat to protect against dependency tree compromises.

How do you want us to proceed? package-lock.json should be in gitignore?

A suggestion would be to fork all deps into bitclouts own repos and then link the package.json to those, requiring approval for upstream changes, etc.

metaspartan avatar Jun 21 '21 17:06 metaspartan