desmos icon indicating copy to clipboard operation
desmos copied to clipboard

Improve `x/posts` structures names

Open leobragaz opened this issue 2 years ago • 3 comments

After reviewing the #893 I've realised that there are some confusing structures names that don't really express the intend of those types. I think both SubspaceDataEntry and PostDataEntry should be renamed to a more meaningful SubspaceRelatedIDs and PostRelatedIDs. This will help to give a better context to the the types and ease the life of devs understanding what they're about.

leobragaz avatar Jun 08 '22 09:06 leobragaz

Those are internal structures, used only when importing/exporting the genesis state. They shouldn't be used by external developers and hence their names. I don't think it's necessary to change them

RiccardoM avatar Jun 09 '22 07:06 RiccardoM

Also for our internal usage that would be useful.

leobragaz avatar Jun 09 '22 08:06 leobragaz

Let's make this extremely low priority then

RiccardoM avatar Jun 09 '22 08:06 RiccardoM