Bin Bao
Bin Bao
> @desertfire Do you know what the ramifications are of the failing ABI compat test for aotinductor? In theory this should be compatible since I am adding kwarg only options...
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D54258087).
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D54258087).
Still need to sort out the internal build issue, but ready for review otherwise.
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D54258087).
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D54258087).
> Seems fine, though my only concern would be code size for the pytorch package. > > We likely only need shims for functions we don't have lowerings/decomps for. Maybe...
> Late to the party. When I modify an operator to add a new optional argument, how does this code generator know to keep the old API function around, and...
> native_functions.yaml doesn't have any notion of BC. When I add a new optional kwarg, I just add a new optional kwarg, I have no way of seeing that in...
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D54258088).