desec-stack icon indicating copy to clipboard operation
desec-stack copied to clipboard

feat(api): adds AXFR retrieve endpoint, without DNSSEC data

Open nils-wisiol opened this issue 5 years ago • 3 comments

Enables the API user to retrieve her zone data as AXFR in one query. Data is taken straight from nslord, but could also be generated by dnspython using the API data in a later version. This is a first shot at #373.

What's still missing:

  • [ ] make sure permissions are set correctly
  • [ ] change the docs

nils-wisiol avatar Jun 03 '20 20:06 nils-wisiol

This is a first shot at #373.

Isn't #373 about import, while this is about export?

peterthomassen avatar Jun 05 '20 09:06 peterthomassen

Isn't #373 about import, while this is about export?

The idea was to have an endpoint that can GET and POST, possibly even PATCH a zone file

nils-wisiol avatar Jun 05 '20 09:06 nils-wisiol

closed accidentally during master branch rename

peterthomassen avatar Apr 14 '21 11:04 peterthomassen

This is a first shot at #373.

Isn't #373 about import, while this is about export?

Merged #601 allows import of zonefiles; this PR allows export. An open question is if we accept updates to zones via zonefiles? (If so, how?) A related question is if we accept presigned zones, i.e. containing DNSSEC RRs.

Docs still missing (will be added after we decided the API).

nils-wisiol avatar Aug 13 '22 14:08 nils-wisiol

Also, the view needs rate limit configuration. I think throttle_scope = "dns_api_write_rrsets" is sufficient (currently 2/s, but per domain).

peterthomassen avatar Aug 24 '22 19:08 peterthomassen

For reference, this (otherwise completely unrelated) comment shows how to mock a "download" with JavaScript: https://github.com/scopewu/qrcode.vue/issues/50#issuecomment-1055585303

peterthomassen avatar Aug 26 '22 19:08 peterthomassen

Before and after merging this, repo config needs to be updated wrt. which checks are required. I suggest making everything required except for the black formatting.

nils-wisiol avatar Aug 26 '22 21:08 nils-wisiol

I'm not planning to add GUI in this PR.

nils-wisiol avatar Aug 26 '22 21:08 nils-wisiol

This looks ready to go and is already rebased on top of #632

nils-wisiol avatar Aug 27 '22 13:08 nils-wisiol

Rebased, and adjusted to things (see conversations above). Can you please review the two fixups?

peterthomassen avatar Aug 30 '22 21:08 peterthomassen

This can be squashed; before merging repo config needs to be adjusted to the new required tests.

nils-wisiol avatar Aug 30 '22 21:08 nils-wisiol

This can be squashed; before merging repo config needs to be adjusted to the new required tests.

Done. - I'm not sure what to adjust. Can you make the changes?

peterthomassen avatar Aug 30 '22 21:08 peterthomassen

Done. - I'm not sure what to adjust. Can you make the changes?

done!

nils-wisiol avatar Aug 30 '22 21:08 nils-wisiol