melgan-neurips icon indicating copy to clipboard operation
melgan-neurips copied to clipboard

Doubt about the defined hinge version Loss

Open hhguo opened this issue 4 years ago • 2 comments

Hi, I am curious about the hinge loss defined in your paper. It seems that your implementation is different.

This is the definition in your paper. image

But you use F.relu in the code, which is max(0, D(x)) image

I tend to believe that the code implementation is correct, so maybe the paper definition is wrong?

hhguo avatar Sep 10 '20 06:09 hhguo

I have the same doubt, too.

allenhung1025 avatar Sep 11 '20 07:09 allenhung1025

I believe the implementation is right, but the paper definition is likely not correct(max instead of min or adding -). May someone confirm it? Thanks.

jamesliu avatar Nov 28 '20 17:11 jamesliu