auth-hosting icon indicating copy to clipboard operation
auth-hosting copied to clipboard

feat(styling and theme): Added Parameter for Styling and Theme

Open gaokevin1 opened this issue 1 year ago โ€ข 5 comments

Related Issues

Description

This PR adds the ability to control styling and theme from a URL query parameter in the Auth Hosting application.

Screenshots

Must

  • [ ] ๐Ÿ“ฑ Responsiveness (mobile/XL resolutions)
  • [ ] ๐Ÿงช Tests
  • [ ] ๐Ÿ“ƒ Documentation (if applicable)

gaokevin1 avatar Aug 19 '24 23:08 gaokevin1

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
auth-hosting โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 3, 2024 4:17pm

vercel[bot] avatar Aug 19 '24 23:08 vercel[bot]

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

vercel[bot] avatar Aug 19 '24 23:08 vercel[bot]

Also @asafshen, do you want another test for this PR besides this one?

test('that the flow can be customized with search params', async () => {
		window.location.pathname = `/${packageJson.homepage}/${validProjectId}`;
		window.location.search = `?debug=${debug}&flow=${flowId}`;
		render(<App />);
		expect(mockDescope).toHaveBeenCalledWith(
			expect.objectContaining({ debug, flowId })
		);
	});

gaokevin1 avatar Aug 20 '24 19:08 gaokevin1

from what I see in the PR in descope-js this was not added yet to react-sdk https://github.com/descope/descope-js/pull/744/files#diff-b24066d0d30844fccfe74b02e0ee2dedf42a1cf7fa1bd6377fe6fd08695fd234 only to web-component at this stage

asafshen avatar Aug 20 '24 19:08 asafshen

Yeah we'll hold off until it's added to the React SDK.

gaokevin1 avatar Aug 20 '24 21:08 gaokevin1

@orius123 can you please review this now?

gaokevin1 avatar Aug 27 '24 21:08 gaokevin1

@gaokevin1 build is failing

orius123 avatar Aug 28 '24 13:08 orius123

@orius123 can you please review again? Build should be passing now.

gaokevin1 avatar Aug 30 '24 15:08 gaokevin1

That's because of my vercel access not because of the build. If you push something you'll see. @asafshen am I good to merge?

gaokevin1 avatar Sep 01 '24 16:09 gaokevin1

This was not added to the dynamicSdk, which means it is not available to customers. So we have a doc that was not tested in production. image

dorsha avatar Nov 07 '24 07:11 dorsha

interesting. I was sure @anvibanga checked it...

gshriki avatar Nov 07 '24 19:11 gshriki

@chris4490 @gaokevin1

anvibanga avatar Nov 07 '24 19:11 anvibanga

Yea I thought I'd checked it as well.

chris4490 avatar Nov 07 '24 19:11 chris4490