feat(styling and theme): Added Parameter for Styling and Theme
Related Issues
Description
This PR adds the ability to control styling and theme from a URL query parameter in the Auth Hosting application.
Screenshots
Must
- [ ] ๐ฑ Responsiveness (mobile/XL resolutions)
- [ ] ๐งช Tests
- [ ] ๐ Documentation (if applicable)
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| auth-hosting | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Sep 3, 2024 4:17pm |
Deployment failed with the following error:
You don't have permission to create a Preview Deployment for this project.
View Documentation: https://vercel.com/docs/accounts/team-members-and-roles
Also @asafshen, do you want another test for this PR besides this one?
test('that the flow can be customized with search params', async () => {
window.location.pathname = `/${packageJson.homepage}/${validProjectId}`;
window.location.search = `?debug=${debug}&flow=${flowId}`;
render(<App />);
expect(mockDescope).toHaveBeenCalledWith(
expect.objectContaining({ debug, flowId })
);
});
from what I see in the PR in descope-js this was not added yet to react-sdk https://github.com/descope/descope-js/pull/744/files#diff-b24066d0d30844fccfe74b02e0ee2dedf42a1cf7fa1bd6377fe6fd08695fd234 only to web-component at this stage
Yeah we'll hold off until it's added to the React SDK.
@orius123 can you please review this now?
@gaokevin1 build is failing
@orius123 can you please review again? Build should be passing now.
That's because of my vercel access not because of the build. If you push something you'll see. @asafshen am I good to merge?
This was not added to the dynamicSdk, which means it is not available to customers.
So we have a doc that was not tested in production.
interesting. I was sure @anvibanga checked it...
@chris4490 @gaokevin1
Yea I thought I'd checked it as well.