plugin.audio.radio_de icon indicating copy to clipboard operation
plugin.audio.radio_de copied to clipboard

Published 20 hours ago • verified publisher icon dersphere

Fix radio.de API limitation of 100 rows

Open ttobsen opened this issue 6 years ago • 10 comments

The radio.de API just returns 100 stations per request. This is not acceptable, especially for the country and language categories where thousands of stations are available.

With this MR, the start parameter is used to loop over all stations of a category. The performance is pretty poor, but at least every station of a category is available.

ttobsen avatar Nov 27 '18 00:11 ttobsen

@ttobsen , @dersphere ,

When is this fix going to be released? I am really waiting for it. It is annoying that the menu items only show the first 100 stations and there is no possibility to browse further.

jcjdammers avatar Dec 18 '19 19:12 jcjdammers

The problem is that @dersphere does not seem to be active anymore. I also tried to get in contact by email, but no chance. I think the only chance is, to fork the project and release it under another name.

ttobsen avatar Dec 18 '19 20:12 ttobsen

@ttobsen and @jcjdammers: Yes, sorry I don't have time for that anymore. You have my permission to do whatever you think makes sense with this addon! You can keep the name or rename it, fork it or can get full ownership of this repository. You can also remove my name from it. Just tell me how you want to proceed and thank you for the time you put into it!

dersphere avatar Dec 19 '19 07:12 dersphere

Hi @dersphere, don't be worry. I'm very happy that someone spent so much time into this app.

If you don't mind, I would fork it on Gitlab.com (because I'm more into Gitlab than Github) and mirror it back to Github, keeping name and everything else (also you as the original author).

Giving me some permissions on this repo would be great. Than I would at least merge the changes to fix this bug and update the README after forking.

ttobsen avatar Dec 19 '19 07:12 ttobsen

You now should have push permission. Sure, sounds good.

dersphere avatar Dec 19 '19 07:12 dersphere

Thanks a lot. Maybe I find some time over winter holiday to optimize the 100 row limitation, the current implementation is very slow.

@jcjdammers You can download the Zip archive from https://github.com/ttobsen/plugin.audio.radio_de/archive/fix-100-rows-limitation.zip and install it manually on your Kodi device. The current fix isn't very perfomant, but I can at least reach every station.

I will create an update where the stations are prefetched. Glad that are winter holidays soon. :smiley:

ttobsen avatar Dec 19 '19 08:12 ttobsen

@ttobsen Many thanks, much appreciated. Will your changes also get pushed to the official Kodi add-on repo?

jcjdammers avatar Dec 19 '19 09:12 jcjdammers

Yes, I will push them, but I first want to reimplement the fix. Currently you can reach all stations, but the addon is slowed down and does not make much fun to handle. In winter holidays, I have some time to do improvements and then push the new version as soon as possible.

ttobsen avatar Dec 19 '19 09:12 ttobsen

@ttobsen Just received the update via Kodi repository. It works great and performance is fast !!! Thanks.

jcjdammers avatar Jan 01 '20 19:01 jcjdammers

@jcjdammers This wasn't me. It seems that the addon is maintained also in the official XBMC addon repository, see https://github.com/XBMC-Addons/plugin.audio.radio_de

I just tried the new version 2.3.2 and it seems that the 100 station limitation is still there. Is this problem fixed in your setup?

Edit: My fault, I forgot to update to latest version :-(

ttobsen avatar Jan 01 '20 21:01 ttobsen