(mistakenly) adding empty custom station creates stutter in playback

[axelsimon]

Hi, first of all thanks for a great add-on. It really is one of the higher quality add-ons on Kodi I know of.

OS: OSMC 2017.08-1 kernel: Linux osmc 4.9.29-9-osmc #1 SMP PREEMPT Sat Jul 29 01:44:42 UTC 2017 armv7l GNU/Linux hardware: Raspberry Pi 2

Here is the issue I ran into. I had a radio playing and while playing around with the Kore remote app, I went into the My Stations and tried to add a radio, using the Add custom radio. I realised this was to add an entirely custom one, so as I didn't have a specific name/thumbnail/URL combination to enter, I just clicked "done" on each text entry. As soon as I clicked "done" without entering text on the third screen (URL entry), the playback started to stutter, making it impossible to listen to. I then stopped playback, started it back up and it played fine.

Here is the relevant part of the log:

20:01:10.946 T:1259336688  NOTICE: [xbmcswift2] Request for "/station/2843" matches rule for function "get_stream_url"
20:01:10.947 T:1259336688  NOTICE: [plugin.audio.radio_de] get_station_by_station_id started with station_id=2843
20:01:10.948 T:1259336688  NOTICE: [plugin.audio.radio_de] __api_call started with path=broadcast/getbroadcastembedded, param={'broadcast': '2843'}
20:01:10.949 T:1259336688  NOTICE: [plugin.audio.radio_de] __urlopen opening url=http://radio.fr/info/broadcast/getbroadcastembedded?broadcast=2843
20:01:11.070 T:1259336688  NOTICE: [plugin.audio.radio_de] get_stream_url result: http://direct.franceinter.fr/live/franceinter-midfi.mp3?ID=pd569ib97j
20:01:16.940 T:1276113904   ERROR: CWebServer[80]: failed to handle HTTP request for /image/
20:03:02.672 T:1533006832   ERROR: Previous line repeats 1 times.
20:03:02.673 T:1533006832  NOTICE: ES: Client  from ::ffff:192.168.0.11 timed out
20:03:36.584 T:1242559472   ERROR: CWebServer[80]: failed to handle HTTP request for /image/
20:07:59.836 T:1072690160   ERROR: Previous line repeats 5 times.
20:07:59.837 T:1072690160  NOTICE: [xbmcswift2] Request for "/" matches rule for function "show_root_menu"
20:08:05.871 T:1072690160  NOTICE: [xbmcswift2] Request for "/stations/my/" matches rule for function "show_my_stations"
20:08:05.871 T:1072690160  NOTICE: [plugin.audio.radio_de] __add_stations started with 0 items
20:08:10.456 T:1072690160  NOTICE: [xbmcswift2] Request for "/stations/my/custom/new" matches rule for function "custom_my_station"
20:08:14.594 T:1242559472   ERROR: CWebServer[80]: failed to handle HTTP request for /image/
20:08:25.352 T:1524618224   ERROR: GetDirectory - Error getting plugin://plugin.audio.radio_de/stations/my/custom/new
20:08:25.913 T:1276113904   ERROR: CWebServer[80]: failed to handle HTTP request for /image/
20:09:09.562 T:1959116800   ERROR: Misplaced [
20:09:09.562 T:1959116800   ERROR: Error parsing boolean expression [Window.IsActive(MyPVRChannels.xml) | Window.IsActive(MyPVRGuide.xml) | Window.IsActive(MyPVRRecordings.xml)] + !String.IsEmpty(ListItem.Plot) + !String.IsEqual($INFO[ListItem.EpisodeName],$INFO[ListItem.Plot])
20:09:12.376 T:1102046192   ERROR: GetDirectory - Error getting
20:10:45.735 T:1533006832   ERROR: Previous line repeats 13 times.

The stuttering has reappeared a few time since, with the 20:19:37.893 T:1456993264 ERROR: CWebServer[80]: failed to handle HTTP request for /image/ line reappearing in the logs.

Hope this is reproducible on your end (or alternatively, that no one runs into this weird condition).

Cheers