legendary icon indicating copy to clipboard operation
legendary copied to clipboard

"Kingdom Come: Deliverance" DLC "The Amorous Adventures of Bold Sir Hans Capon" files are downloaded to wrong folder

Open DanielGaaA opened this issue 10 months ago • 7 comments

Platform

Operating system and version: Opensuse tumbleweed 20250205 Legendary version (legendary -V): 0.20.36 Urban Flight (Heroic)

Current Behavior

Some DLC files are downloaded to wrong folder localization instead of correct folder Localization due to case sensitive linux filesystem. On windows this is not issue because NTFS is case-insensitivity and files will be put in already existing Localization folder. This will break wine/game

Image

Expected Behavior

Files should be put in correct folder.

Steps to Reproduce

  1. Install Kingdom Come: Deliverance and launch game. Game menu text is ok. Image

  2. Install DLC "The Amorous Adventures of Bold Sir Hans Capon" and launch game. Game menu is broken as on the screenshot Image

  3. I had to manually move files from localization to Localization and delete localization folder to fix the game.

DanielGaaA avatar Feb 10 '25 14:02 DanielGaaA

I can't really fix that. Ideally the folder containing games should probably be set to be case insensitive, not sure if we can do that automatically when creating it during installation or if that requires root privileges.

derrod avatar Feb 10 '25 17:02 derrod

Hello, I tried new legendary build but it didn't fix issue.

DanielGaaA avatar Feb 11 '25 16:02 DanielGaaA

Hey, sorry, had a little logic error in the change there. Could you re-test with my updated changes?

CommandMC avatar Feb 11 '25 18:02 CommandMC

Installation of DLC was successful and files were in correct location, but uninstalling DLC didn't delete the files.

/legendary uninstall EelAmorous
Do you wish to uninstall "The Amorous Adventures of Bold Sir Hans Capon"? [y/N]: y
[cli] INFO: Removing "The Amorous Adventures of Bold Sir Hans Capon" from "/home/daniel/Games/KingdomComeDeliverance"...
[LFS Utils] ERROR: Failed deleting file localization/Czech_DLC2.pak with FileNotFoundError(2, 'No such file or directory')
[LFS Utils] ERROR: Failed deleting file localization/English_DLC2.pak with FileNotFoundError(2, 'No such file or directory')
[LFS Utils] ERROR: Failed deleting file localization/French_DLC2.pak with FileNotFoundError(2, 'No such file or directory')
[LFS Utils] ERROR: Failed deleting file localization/German_DLC2.pak with FileNotFoundError(2, 'No such file or directory')
[LFS Utils] ERROR: Failed deleting file localization/Japanese_DLC2.pak with FileNotFoundError(2, 'No such file or directory')
[LFS Utils] ERROR: Failed removing directory "Data" with OSError(39, 'Directory not empty')
[Core] ERROR: Deleting "/home/daniel/Games/KingdomComeDeliverance" failed, please remove manually.
[cli] INFO: Game has been uninstalled.

DanielGaaA avatar Feb 11 '25 18:02 DanielGaaA

Installed DLC again to test verify function and it also report files in wrong folders. Repairing downloaded files again but put them in correct location

/legendary verify EelAmorous
[cli] INFO: Loading installed manifest for "EelAmorous"
[cli] INFO: Verifying "The Amorous Adventures of Bold Sir Hans Capon" version "1.9.5.404-503czj3"
[cli] ERROR: File is missing: "localization/Czech_DLC2.pak"
[cli] ERROR: File is missing: "localization/English_DLC2.pak"
[cli] ERROR: File is missing: "localization/French_DLC2.pak"
[cli] ERROR: File is missing: "localization/German_DLC2.pak"
[cli] ERROR: File is missing: "localization/Japanese_DLC2.pak"
Verification progress: 6/6 (0.0%) [0.0 MiB/s]
[cli] ERROR: Verification failed, 0 file(s) corrupted, 5 file(s) are missing.
[cli] INFO: Run "legendary repair EelAmorous" to repair your game installation.

DanielGaaA avatar Feb 11 '25 18:02 DanielGaaA

Ah, I see. I only looked at the download functionality for now, so good thing that's working. Will take care of the rest now

CommandMC avatar Feb 11 '25 18:02 CommandMC

Looks good now

./legendary verify EelAmorous
[cli] INFO: Loading installed manifest for "EelAmorous"
[cli] INFO: Verifying "The Amorous Adventures of Bold Sir Hans Capon" version "1.9.5.404-503czj3"
Verification progress: 6/6 (100.0%) [0.0 MiB/s]
[cli] INFO: Verification finished successfully.
./legendary uninstall EelAmorous
Do you wish to uninstall "The Amorous Adventures of Bold Sir Hans Capon"? [y/N]: y
[cli] INFO: Removing "The Amorous Adventures of Bold Sir Hans Capon" from "/home/daniel/Games/KingdomComeDeliverance"...
[LFS Utils] ERROR: Failed removing directory "localization" with OSError(39, 'Directory not empty')
[LFS Utils] ERROR: Failed removing directory "Data" with OSError(39, 'Directory not empty')
[Core] ERROR: Deleting "/home/daniel/Games/KingdomComeDeliverance" failed, please remove manually.
[cli] INFO: Game has been uninstalled.

DanielGaaA avatar Feb 12 '25 07:02 DanielGaaA