phpsaml icon indicating copy to clipboard operation
phpsaml copied to clipboard

Update routine not triggered correctly on migrate

Open DonutsNL opened this issue 2 years ago • 0 comments

https://github.com/derricksmith/phpsaml/blob/988157eb826e44bccfc8b96c8b3c8e468494e1a2/hook.php#L82

We need to refactor this a bit to make sure the update routine is triggered properly. Prob we need to use the Migrate object.

As a work arround the routine is now also triggered if the database column count is different then what was expected. As an corrective measure the update is triggered by the config.class.php here :

https://github.com/DonutsNL/phpsaml/blob/4deac6e7c7fe42446d2839f0ae1e8ca3f7a45bc3/inc/config.class.php#L250

This should 'idealy' never get triggered...

DonutsNL avatar Jun 23 '23 21:06 DonutsNL