Cheskel Twersky comments

Results 28 comments of


                                            Cheskel Twersky

Errors are not sent back to the caller

``` errno: -1 code: -1, message: 'timed out', origin: 'local', message: [LibrdKafkaError: Local: Timed out] { { } timestamp: 1717074108080 fac: 'FAIL', message: '[thrd:sonic-cluster-broker-0.kafka.internal.triplestack.io:9092/0]: sonic-cluster-broker-0.kafka.internal.triplestack.io:9092/0: 2 request(s) timed out: disconnect...

Errors are not sent back to the caller

this is coming from librdkafka, i had extracted it from gcp, that why it might look a little different you can see the `timestamp ` is there too

Failed to "ack" for 3000 message(s). Reason: 3 INVALID_ARGUMENT: Request payload size exceeds the limit: 524288 bytes

im testing a fix by adding a `maxBytes` param, to make sure it doesnt pass the threshold

Streaming/batched publishers

is there something built in to the spec for batch publishing?

Support batch publishes

I think adding a method to the client libraries that takes in multiple messages and compresses them and sends them all at once is what would lead to the performance...

node-local-dns-cache DNS i/o timeout errors at startup

@rahul656 did it help?

fix: check the X-ClickHouse-Exception-Code for err code

ok, so this solves a similar issue we had, should i open a separate issue for that?

fix: check the X-ClickHouse-Exception-Code for err code

in theory the error should be parsed just fine, since it's using regex to find the error from the body: https://github.com/ClickHouse/clickhouse-js/blob/00af5c2cd90d7d37775158052e3e072be091c393/packages/client-common/src/error/parse_error.ts#L2 ill try to get a test in too