spring-data-dynamodb icon indicating copy to clipboard operation
spring-data-dynamodb copied to clipboard

Does not work with Spring Boot 2.2.1 / Spring Data 2.2.1

Open patkovskyi opened this issue 6 years ago • 10 comments

Expected Behavior

Works with Spring Boot 2.2.1 / Spring Data 2.2.1

Actual Behavior

Does not work with Spring Boot 2.2.1 / Spring Data 2.2.1

Steps to Reproduce the Problem

  1. Use Spring Boot 2.2.1 without specifying implementation 'org.springframework.data:spring-data-commons:2.2.0.RELEASE'.
  2. DynamoDB repository beans are not created (org.springframework.beans.factory.NoSuchBeanDefinitionException).

Workaround (need to verify if everything is really ok): Downgrade Spring Data to 2.2.0: implementation 'org.springframework.data:spring-data-commons:2.2.0.RELEASE'

Specifications

Spring Data DynamoDB Version: 5.1.0 (2.1) Spring Data Version: 2.2.1.RELEASE AWS SDK Version: 1.11.443 Java Version: 12.0.2 - OpenJDK 64-Bit Server VM 12.0.2+10 Platform Details: Mac OS X 10.14.6

patkovskyi avatar Nov 08 '19 11:11 patkovskyi

This is due to lack of multiple repository support probably. I have a fix incoming sometime soon.

boostchicken avatar Nov 16 '19 11:11 boostchicken

@patkovskyi
Fixed in 5.2.1-SNAPSHOT under my fork, if you could open an issue on my repo for tracking purposes I would appreciate it. That is OSSRH snapshots, have a release soon.

repositories {
        mavenCentral()
        maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
    }

api group: 'io.github.boostchicken', name: 'spring-data-dynamodb', version: '5.2.1-SNAPSHOT' https://github.com/boostchicken/spring-data-dynamodb

boostchicken avatar Nov 19 '19 09:11 boostchicken

api  group: 'io.github.boostchicken', name: 'spring-data-dynamodb', version: '5.2.1'

On maven central now

boostchicken avatar Nov 19 '19 11:11 boostchicken

@boostchicken I was seeing this issue. Your new version has fixed it. Thanks for that.

Have you just volunteered to take over development and maintenance of the repo? 😉

boothen avatar Nov 20 '19 10:11 boothen

@boothen Feel free to follow my repo, I will continue to support it. Contributions welcome :)

boostchicken avatar Nov 22 '19 22:11 boostchicken

Does this Fix come also get into this repository?

tobiashochguertel avatar Jan 02 '20 08:01 tobiashochguertel

When will you release it as a new version of spring-data-dynamodb?

btyoshidakim avatar Jan 15 '20 01:01 btyoshidakim

io.github.boostchicken

will this be merged to this repo is there a PR ?

gauravbrills avatar Jul 24 '20 16:07 gauravbrills

@gauravbrills I would say no. Move to my fork.

boostchicken avatar Jul 25 '20 04:07 boostchicken

@gauravbrills I would say no. Move to my fork.

Yup doing the same for now but can't there be one standard repo or if spring cloud aws or data can merge this in the main stream. This has now shifted across 3 repos now.

@derjust any update if this can be merged

gauravbrills avatar Jul 26 '20 00:07 gauravbrills