puppet-zookeeper icon indicating copy to clipboard operation
puppet-zookeeper copied to clipboard

Fix Warning with updated Stdlib

Open cocker-cc opened this issue 2 years ago • 3 comments

Fix Warning ”This function is deprecated, please use stdlib::merge instead.”

cocker-cc avatar Sep 27 '23 13:09 cocker-cc

Thanks, that's a nice idea to get rid of that warning. But it would bring too many issues with backwards compatibility :disappointed: It this case it might be easier to avoid using stdlib::merge function. Jumping from version 2.x to 9.x is just too much for a warning.

deric avatar Sep 27 '23 19:09 deric

Jumping from version 2.x to 9.x is just too much for a warning.

Are you serious? stdlib Version 2.6.0 is dated 2012.
Puppet in general is heading towards namespaced Functions.

cocker-cc avatar Sep 27 '23 21:09 cocker-cc

It only means that 2.6.0 API should be backwards compatible. I hope nobody is using it anymore. 9.0.0 is just 5 months old any many modules (almost every module depends on puppetlabs-stdlib) haven't upgraded their dependencies. With such change we'll create a dependency hell. I guess most modules now require stdlib 7.0 or 8.0. In another module we had to revert the upgrade to 9.0. Making breaking changes simply takes time. If we make such change then we have to maintain at least 2 branches and backport all changes.

deric avatar Sep 29 '23 07:09 deric

Closing in favor of 55fa295.

deric avatar Jun 24 '24 14:06 deric