puppet-zookeeper icon indicating copy to clipboard operation
puppet-zookeeper copied to clipboard

version-2 directory has an unnecessary init check

Open minorOffense opened this issue 6 years ago • 1 comments

https://github.com/deric/puppet-zookeeper/blob/master/manifests/config.pp#L81 Uses a flag to check if the data directory needs to be initialized. This is unnecessary because the "creates" flag on the exec will automatically know if it needs to run based on the presence of that file.

minorOffense avatar Sep 26 '19 19:09 minorOffense

I guess the motivation was that in some cases calling zookeeper-server-initialize might not be considered as dangerous.

deric avatar Sep 27 '19 13:09 deric