Tomas Barton
Tomas Barton
@jordanbreen28 Rebased.
Generally I like the changes, don't be mistaken by too many comments. Definitely we have to fix the tests and try not to break current behaviour. If the changes would...
It would be nice to separate this into multiple PR, or create at least an issue for systemd support.
@blsmth What kind of issues you're having? Could you create a separate issue, so that we can address then individually?
@clehene cool, looks much better! What's the reasoning for introducing `mesos::common::mkdir_p`? Can't we just use: ``` puppet file{'/some/path': ensure => present, recurse => true, } ``` otherwise we have to...
@clehene What is the reason for removing all: ``` puppet owner => $owner, group => $group, ``` does it cause problems on RHEL7? Can't we just set `$owner = undef`,...
Ok, sorry. I've overlooked that.
We should introduce some parameter `configure_via => env_vars` (or `files` for using `/etc/mesos-slave`, `/etc/mesos-master`) which would avoid having same configuration at two places.
This PR is getting too old and some of the issues mentioned are probably already solved, please let me know if any of the issues still persists. I'll try to...
Could you provide more details about your setup? Puppet, Ruby version, etc. Which version of `puppet-mesos` do you use? There's a [spec](https://github.com/deric/puppet-mesos/blob/c4afdb8023fee48d1d6b9a9976ecfbd0197025ea/spec/classes/config_spec.rb#L60) that seems to be passing on all [tested...