feh icon indicating copy to clipboard operation
feh copied to clipboard

somewhere along the way my --cycle-once themes broke

Open Eli-the-Bearded opened this issue 2 years ago • 2 comments

I've been using feh since nearly forever (slide show delay as a float was a feature request of mine in 2000, for previewing video frames as an animation).

I use themes and wrapper scripts for various types of uses. My quick peruse images fehonce uses --cycle-once and until today I've been wondering why that option errors out. Today I got sick of living with it and scoured the git log to figure out what happened.

Any objections to a PR to comment in the documentation that "--on-last-slide=quit has the functionality of the old --cycle-once option" so that future me (or people like me) can actually figure out where that option went?

(I'm guessing you really don't want to add it back even though it doesn't conflict with any newer command line options. It's shorter to type.)

Eli-the-Bearded avatar Jun 21 '23 01:06 Eli-the-Bearded

Any objections to a PR to comment in the documentation that "--on-last-slide=quit has the functionality of the old --cycle-once option" so that future me (or people like me) can actually figure out where that option went?

None at all, please go ahead! I didn't think of that when deprecating and removing the feature.

In my opinion, feh has a staggering amount of options, so I try not to add to them too much and reduce redundancy where possible. Hence I'd rather not re-add cycle-once to the documentation. I might re-add the long option to the source code though; I'll think about that.

derf avatar Jun 21 '23 15:06 derf

In my opinion, feh has a staggering amount of options

All the best programs, do, though, right? mplayer, gcc, ffmpeg... :^)

Eli-the-Bearded avatar Jun 26 '23 00:06 Eli-the-Bearded