media-embed icon indicating copy to clipboard operation
media-embed copied to clipboard

oEmbed fallback / new major

Open dereuromark opened this issue 4 years ago • 2 comments

It looks like soundcloud supports oEmbed. I think it makes sense to implement support for generic oEmbed resources instead of implementing a soundcloud specific solution. We could use an oembed php library and try to use oEmbed to get the embed code for all unknown services.

(from https://github.com/dereuromark/media-embed/issues/43 )

I think we can start a new 0.x major as develop branch with all the necessary improvements there. What do we want to look out for? I don't know much about this new oEmbed topic yet.

My main topics for a generic new major would be:

  • [ ] try to have value objects for the providers/services/stubs elements
  • [ ] allow easier custom injection/overwrite per service if needed (inside this provider collection)
  • [ ] more OOP approach then instead of array access and string assoc key arrays.
  • [x] PHP 7.1+ ( https://github.com/dereuromark/media-embed/issues/41 ) with typehinting?

The specific oEmbed things are maybe something you can outline.

dereuromark avatar Nov 01 '19 17:11 dereuromark

We could use this library to get oEmbed information of an url.

https://github.com/oscarotero/Embed

derUli avatar Nov 02 '19 10:11 derUli

That looks quite interesting!

dereuromark avatar Nov 02 '19 10:11 dereuromark