Mark Scherer comments

Results 898 comments of


                                            Mark Scherer

Specifying Cake\Validation\Validator::decimal() $places parameter causes validation to fail

It could be that float is not a valid type for a decimal check (since float doesnt have the precision/scale by nature). I added a live demo for decimal: https://sandbox.dereuromark.de/sandbox/decimal-examples/validation/de_AT?value=1234%2C56...

Specifying Cake\Validation\Validator::decimal() $places parameter causes validation to fail

I am not too familiar with ES, but it seems to want a comma as decimal separator: https://sandbox.dereuromark.de/sandbox/decimal-examples/validation/es?value=1234%2C56 Not sure but it sounds more like the intl locale parser might...

Strip delimiter characters in setPattern() regex strings

Do you want to make a PR here?

EntityRoute does not support enum fields

Do you want to make a PR for 5.next to add support for this?

Error templates

See https://github.com/cakephp/app/pull/970 also

Support custom confirmJs on postLink (with access to formName of parent::postLink)

It would be easier to directly make PRs here

Support custom confirmJs on postLink (with access to formName of parent::postLink)

You can keep it open for now, no worries. Maybe others would like to also give some early feedback.

DebugKit not showing on fresh CakePHP 5 installation

Did you try running a docker container setup and see if that works? Instead of using the native PHP/SQL stack on your system? On my linux mint I for example...

DebugKit not showing on fresh CakePHP 5 installation

If there is not much more there can be done, I wonder if we should close.

migration_diff generates incorrect code for decimal column definition change

Might this be fixed by https://github.com/cakephp/migrations/pull/571 ?