Mark Scherer
Mark Scherer
Do you have a contact or github name or alike we can reach out to? You can send email or alike also privately in an email to me or Denis.
@mwringler and team: Do we have any feedback on this regarding the topic at hand? Do we want to adjust here something in terms of next beta release?
We now have master almost green ( https://travis-ci.org/github/propelorm/Propel2 ) Please try to rebase yours against that one, that will make it easier to verify your changes. Do you happen to...
Before, `if (!trim($change)) continue;` took care of empty rows You might want to check what your changed method returns here instead.
Is someone able to make a PR here with suggested changes?
Can you also rebase on top of latest master? Then we should be able to proceed.
If you use PHP8+, many libs are PHP7/8 for quite some time still, though. So yeah, I would consider this a code smell still in projects and it would be...
Currently https://github.com/propelorm/Propel2/pull/1849 dos the opposite, it adds new not-null return methods where needed. This keeps the current API and therefore less BC breaks for now We should use has() none...
Is someone able to make a PR here with suggested changes?