Mark Scherer

No, I would prefer if we have only one major behind on Master. Bad enough as it is :)

@nyamsprod Are you interested in making a PR with the suggested improvements? That would be great.

I also dont like that marshaling a time value of H:i:s it becomes a string with datetime 11/3/2020 11:15AM etc If you directly echo the string, you have weird results....

Especially the output format (xml, json) is important for it to be used programatically.

I guess this wasnt pursued further so far? The links above to the existing ones are 404 by now. Maybe someone knows the new URLs?

Why not just also removing this trailing comma here? That would make most sense IMO, as the comma is not expected there as you said, so it should be safe...

Interesting, I would have placed it in the same sniff as this one on its own (without others) is responsible for a safe and complete replace of the two lines...

> But whatever I do, it's a BC break because PHPCS is working differently than before. I dont think so, it is currently failing (breaking hard as it not further...

> You and I might not, but don't assume nobody does Sure, but then they wouldnt use any of those sniffs in the first place. Given the setup I mentioned,...

We managed to add https://github.com/spryker/code-sniffer/pull/313 in order to remove the silencing again. Maybe such a sniff should be part of those sniffs natively, but for us this works. We can...