cakephp-ide-helper icon indicating copy to clipboard operation
cakephp-ide-helper copied to clipboard

Add load identifier task

Open toggenation opened this issue 2 years ago • 4 comments

Hi @dereuromark, This is my attempt at a PR to add type hinting to the AuthenticationService::loadIdentifier() method

I think the reason your phpstorm meta file works in VSCode is the PHP Intelephense plugin (bmewburn.vscode-intelephense-client).

I've tried to write a test but I'm not sure it's right. When I run it, it succeeds and then randomly fails.

Also I don't know how to squash these commits into one... still a git newbie.

Hope you can use it despite this.

Thanks for this plugin. Very useful

toggenation avatar Sep 02 '22 06:09 toggenation

Hi! I wonder since this isnt a native core topic, but a plugin: https://github.com/dereuromark/cakephp-ide-helper#more Wouldnt it be better suited in the IdeHelperExtra one?

Otherwise looks good :)

dereuromark avatar Sep 02 '22 06:09 dereuromark

Hi!

Okay, Will have a look at how to move it into more https://github.com/dereuromark/cakephp-ide-helper-extra

Apologies @dereuromark I'm bumping up to the limit of my understanding on this so may need to take a while to figure out how to move it into the IdeHelperExtra plugin...

Maybe if I do a YT video on it I will understand it. Seems to become clear when having to explain it to others.

Thanks again I used bin/cake annotate controllers and it immediately fixed the $this->Authentication auto complete issue I had in vscode too.

toggenation avatar Sep 02 '22 06:09 toggenation

I added the note about the IDE here: https://github.com/dereuromark/cakephp-ide-helper/commit/497e960efdadb296ce23629e915592bf02f8fd90

dereuromark avatar Sep 02 '22 06:09 dereuromark

Codecov Report

Merging #282 (497e960) into master (35f580b) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 497e960 differs from pull request most recent head 22d9361. Consider uploading reports for the commit 22d9361 to get more accurate results

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage     87.20%   87.20%           
  Complexity     1612     1612           
=========================================
  Files           101      101           
  Lines          4392     4392           
=========================================
  Hits           3830     3830           
  Misses          562      562           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 02 '22 06:09 codecov-commenter

https://github.com/dereuromark/cakephp-ide-helper-extra/pull/3

dereuromark avatar Sep 19 '22 10:09 dereuromark