stubborn icon indicating copy to clipboard operation
stubborn copied to clipboard

Feedback

Open derekdowling opened this issue 9 years ago • 0 comments

  • [ ] is_a() please use the language construct instanceof its faster.
  • [ ] Stubborn.php#L233 You want self:: I think rather than static::
  • [ ] Your using Exceptions for your events.. seems abit fugly.. quick fix solution might be a have an EventException, throw new EventException(Event::STOP_TIMING), rather than having a class called "StopEvent" which actually extends an Exception but doesn't live in the Exception folder or named "StopEventException".. even then this seems odd using Exceptions for Events. using the Symfony EventDispatcher would be Ideal.

derekdowling avatar Nov 19 '14 15:11 derekdowling