Derek Ho

Results 115 comments of Derek Ho

> @derek-ho Please fix these failing tests https://github.com/opensearch-project/opensearch-py/actions/runs/8072055726/job/22087332746 I am pretty sure the without security tests are not because of this change - I see them failing on other PRs...

Related to: https://github.com/opensearch-project/security-dashboards-plugin/issues/1196

I am not sure about how feasible this is, especially if a mechanism doesn't exist today, meaning that only newer versions would have this list at runtime - it wouldn't...

Another option that may be better than adding an API to all versions would be to just copy over the permissions list per version and try to read from that....

@junqiu-lei @RobSaxonNokia this seems like a maps issue, can we move it there?

I don't think so, but let me try to reproduce

@kavilla I was not able to reproduce the bug. I believe we are already hiding that call behind the config's value for multi tenancy enabled here: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/server/plugin.ts#L178. Can you share...

@ruanyl @kavilla still not able to reproduce this issue - can you share your `opensearch_dashboards.yml`, as well as your backend security config?

https://github.com/opensearch-project/security-dashboards-plugin/pull/1899 was merged

I rechecked this and feel like it is fine to have a helper function used only in one place. It could reduce number of files, but maybe not worth the...