Derek Gerstmann

Actually, it looks like the module CMakeLists.txt DOES search for FFMPEG, it just doesn't add the FFMPEG_INCLUDE as an option to the build. And it only looks in '/usr/include/ffmpeg', so...

I believe most of the errors were from the use of the DIRECTORY component specified as a parameter to get_filename_component. CMAKE v2.8x used PATH, and CMAKE v3.x introduced DIRECTORY: https://cmake.org/cmake/help/v3.0/command/get_filename_component.html

> C:\build_bot\worker\halide-testbranch-main-llvm16-x86-64-windows-cmake\halide-source\src\CodeGen_Vulkan_Dev.cpp(1082): error C2398: Element '3': conversion from 'SpvBuiltIn_' to '_Ty' requires a narrowing conversion with [ _Ty=uint32_t ] Oooh, thanks! I'll fix this!

> Generally looks very nice; my comments are mostly nits but a few actionable items. My main concern here is that there are a lot of TODO comments (and also...

> Monday Morning Review Ping -- where does this PR stand? Apologies … I’m on vacation but will be back later this week! Most of the requested changes are pushed...

Ready for review!

> Linux failures appear to be real, PTAL Strange. The arm-64-linux failure seems to come from a typo in tests/correctness/target.cpp which isn't part of my changes. I'll merge with main...

Ready to merge! All tests are now passing on my tested configs for Linux & Windows using the target `host-vulkan-vk_int8-vk_int16-vk_int64-vk_float16-vk_float64-vk_v13` on LLVM v14.x. More details in the VULKAN_readme.md regarding current...

Added issues: #7202 #7203

> Question for schedule estimation: after this PR lands, do we expect this to be a functional (although perhaps alpha- or beta- quality) backend? Or are there more things we...