explorerplusplus icon indicating copy to clipboard operation
explorerplusplus copied to clipboard

Prefer constexpr over const

Open skyline75489 opened this issue 4 years ago • 3 comments

This isn't all of them. If you like how it goes, I'll file another PR to address the rest.

skyline75489 avatar Mar 11 '21 13:03 skyline75489

@skyline75489 could you explain what this is supposed to improve/make less fragile? I guess, some explanation (may be a link to a language guideline?) will help @derceg to decide whether this should be merged

YakovL avatar Sep 12 '21 13:09 YakovL

Thanks for the pull request, I think this change is worth making.

As there have been a number of updates since this pull request was created, it won't merge as-is (e.g. because some of the constants have been removed). Could you rebase your changes on top of master?

In terms of a second pull request, that makes sense. For consistency, at least, I think it's best to have all of the existing instances updated, either in one pull request, or two.

derceg avatar Nov 21 '22 12:11 derceg

seems constexpr const is better?

hsupu avatar Feb 18 '23 17:02 hsupu