explorerplusplus
explorerplusplus copied to clipboard
When "Show gridlines in details view" is unchecked, vertical column lines remain
Describe the bug In details view, vertical gridlines remain even though "show gridlines in details view" is unchecked.
To Reproduce Steps to reproduce the behavior:
- Go to Tools | Options | Window | Listview
- Uncheck "Show gridlines in details view", press ok
- Change view to Details
- See vertical gridlines separating columns
Expected behavior No vertical gridlines.
Version (please complete the following information):
- Explorer++ version: June 22, 2020 dev 64-bit-build commit 35c3a2bb50c0e0faec42637679c686b989af4403
- OS: Win 10 1903
Additional context
In default light theme, in ShellBrowser::SetupListView
, the call to SetWindowTheme(hListView, L"Explorer", nullptr);
causes the vertical lines. Commenting out that call fixes the issue, but has the side-effect of causing item selection to be colored blue.
In the new dark theme, in DarkModeHelper::SetListViewDarkModeColors
, the call to SetWindowTheme(listView, L"ItemsView", nullptr);
causes the vertical lines. Commenting out that call fixes the issue, but has the side-effect of causing item selection to be colored blue (colored white when inactive), and scrollbar not colored correctly (though it is incorrect with ItemsView window theme as well; Explorer theme does color scrollbars correctly).