Lukasz Gornicki comments

Results 1796 comments of


                                            Lukasz Gornicki

check if we can have one `integration.test.js` with snapshots for all websocket client under `websocket/test` with as less code duplication as possible

@ItshMoh will work on it

check if we can have one `integration.test.js` with snapshots for all websocket client under `websocket/test` with as less code duplication as possible

some details in https://github.com/asyncapi/generator/issues/1505 already

check if we can have one `integration.test.js` with snapshots for all websocket client under `websocket/test` with as less code duplication as possible

yeah, I'm also interested in more details on approach `3`

[Security] ws package vulnerability through puppeteer@14

affects only users that use pdf generation flag

[Security] ws package vulnerability through puppeteer@14

will be fixed with https://github.com/asyncapi/html-template/issues/256

[FEATURE]: Make `compile` option default to `false` in future major release

this has to be done together with additional documentation that explains the compilation/transpilation concept + explanation on how to publish a template with transpilation files included -> https://github.com/asyncapi/html-template/pull/575

[BUG] Docker container html template is not compatible with generator

Hey there, sorry for late response - vacation and some other harder moments in life 😄 > It is downloading latest (2.3.9) html-template automatically what do you mean? docker image...

[📑 Docs]: Fix the relative paths of `index.md` & `migration.md` files.

@Gmin2 but the paths should be valid only for asyncapi.com, where docs are rendered, not here in docs

[📑 Docs]: Fix the relative paths of `index.md` & `migration.md` files.

not sure what links you have in mind exactly, can you share an example?

add new type of client - for Kafka protocol

yeah 100% not hermes. The one you mentioned seems to be the best match