Lukasz Gornicki
Lukasz Gornicki
From my perspective - all good. So once you separate the component as @akshatnema mentioned, we are ready to go
@AceTheCreator as contributor, next to failing check, don't you see `Details` link? here is what logs in details say: ``` Error: 1 result for https://deploy-preview-2898--asyncapi-website.netlify.app/en Report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1718220903993-56479.report.html ❌ `categories.best-practices` failure...
@akshatnema I guess you can approve and merge
what happens with https://github.com/asyncapi/website/blob/master/markdown/docs/tutorials/getting-started/hello-world.md tutorial? shouldn't one of new once replace it with same filename but different title (asking because of dead links)
then we need redirect from old link to a new one, for external resources that link to the current document, to not cause dead links
here: https://github.com/asyncapi/website/blob/master/public/_redirects
I don't think we need it, not much interest from the community visible here
@ayushnau 1. Regarding your comment about `@changesets/cli` that can be used with npx, but changelong-git must be installed. Please adda proper comment to YAML file, with link to an issue,...
@ayushnau please notice that in my comment about docs there were 2 screenshots about two different docs
also I see tests are failing, did you change do ker compose setting as mentioned in slack?