k9s icon indicating copy to clipboard operation
k9s copied to clipboard

Rename "kill"

Open keeganwitt opened this issue 4 years ago • 7 comments

I think the name "kill" might be confusing, since what it's really doing is deleting without bringing up the prompt. To some it might sound like "kill" means something like https://github.com/derailed/k9s/issues/287. Names are hard, but I was thinking something like "quick delete" or "delete (no prompt)" might be clearer.

keeganwitt avatar Jun 25 '20 02:06 keeganwitt

This is especially the case for unmanaged pods, since it won't "kill" the process, the pod will be permanently gone. As an alternative to renaming (or perhaps in addition to renaming), I think k9s should not show the "kill" option for unmanaged pods.

keeganwitt avatar Jun 25 '20 02:06 keeganwitt

Additionally, I would like to disable "Kill" entirely - at least via configuration. Killing a pod without prompt can result in ... embarrassing (employment ending?) outages in production and it would be ideal to remove it as a possibility entirely!

noahlz avatar Oct 15 '20 16:10 noahlz

Running k9s in --readonly mode is an option to prevent users from accidentally killing a pod, but there really should be an option to enable kill and delete prompts.

jordanmat avatar Aug 16 '22 15:08 jordanmat

@noahlz but your employee can run kubctl delete and confirm it.

slimus avatar Aug 23 '22 15:08 slimus

I confirm that it's confusing for none k8s professionals, people are confused using k9s and think that there is an extra behavior behind kill compared to delete. Also it's better to always have the prompt for the UI deletion ...

GeoffreyStemys avatar Mar 18 '24 09:03 GeoffreyStemys

I'm here because i just accidentally killed a most of a production replacaset. I had marked them so as to help me remember which ones i needed to update next, move over to the next in my list and hit kill. I immediately realised my error as i watched everything change to "terminating", and got to work on the recovery but this would easily have been prevented by seeing the prompt from the delete saying how many pods were getting deleted. Im definately in the camp or being able to turn off this option if its doing the same as the delete anyway.

lumattr avatar Apr 30 '24 12:04 lumattr