k9s icon indicating copy to clipboard operation
k9s copied to clipboard
verified publisher icon derailed

add support for custom emoji

Open imorte opened this issue 10 months ago • 10 comments

resolves #2624

imorte avatar Mar 09 '25 16:03 imorte

@derailed Hello! May you check it please?

imorte avatar Mar 09 '25 17:03 imorte

@imorte Thank you for this PR!

I am not super keen on the current approach for these reasons:

  1. I feel these should be part of a skin vs k9s config. As such it won't crowd up the main config and it's really a stylistic concern. Also folks could share their emojis using existing styles mechanics. So the styles could now reference a file i.e something like emojis/standard or emojis/custom-1 in their skin file and load up the respective emojiis.
  2. Emojis names should be namespaced i.ie something like prompt.filter, prompt.query, status.warn, status.info
  3. Not keen on defining each emoji kind as a new accessor. Better to use a generic call something like emojiFor(xxx). This allows to CRUD icons in the future with minimal effort.

What do you think?

derailed avatar Mar 10 '25 17:03 derailed

@derailed Thanks for the response! Yes, it all sounds reasonable. I will do it this way

imorte avatar Mar 11 '25 09:03 imorte

@imorte Thank you! Also... as I just got reminded... we need to make sure that none of these are activated when noIcons flag is enabled.

derailed avatar Mar 11 '25 16:03 derailed

@derailed done, I hope I didn't forget anything

I haven't touched this func yet https://github.com/derailed/k9s/blob/e36716a3ffcfc1b06787aebbf53fa45f5eb36d76/internal/render/dir.go#L49

What do you think, is it worth spending time adding the config here now, or can we do it later?

imorte avatar Mar 23 '25 13:03 imorte

@derailed Hi, what do you think about this PR? I can rebase and adapt it for the new version

imorte avatar Apr 09 '25 12:04 imorte

@derailed Just wanted to follow up on this PR - happy to make any changes if needed

imorte avatar May 04 '25 18:05 imorte

please merge this @derailed, this would be so useful.

szechp avatar May 08 '25 10:05 szechp

@imorte Thank you for these updates. Looks like we have conflicts, can you take a peek?

derailed avatar Jun 01 '25 13:06 derailed

@derailed will resolve soon!

imorte avatar Jun 03 '25 12:06 imorte

Would really like to use this!

gavin-foster-obvs avatar Jun 23 '25 09:06 gavin-foster-obvs

not forgotten! I'll try to find time soon

imorte avatar Jul 23 '25 12:07 imorte

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Aug 23 '25 02:08 github-actions[bot]