Include sidecar containers requests and limits
Description
With sidecar containers that went Beta in kubernetes 1.29, the Pod 'summary' values for resource requests, limits and percentage are skewed. While the actual cpu/memory usage is a sum of all containers in the pod, the request and limits does not currently include sidecars.
Proposition
Add req/lim of sidecar containers to the sum of req/lim used for the Pod render view.
Alternative
I considered the alternative of simply excluding cpu/mem usage of containers, only for the percentage calculations on the Pod view. Therefore instead of including sidecars in the sum of req/lim, we could instead discard metrics of sidecar containers when we compute the %CPU/L, etc... However, it feels like we would loose information by doing this, as sidecars are no different than the regular containers for the health of an application, and are often critical to the health of a workload (e.g. istio)
Reference:
https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/#resource-sharing-within-containers
I noticed that the pr build was broken by a previous merge. I made separate pull request to fix it #2856
@ebisso I think we may want to rebase to pick up your latest pr. Thank you!
@derailed I rebased on master, it should be good to go now! Thanks!