k9s icon indicating copy to clipboard operation
k9s copied to clipboard
verified publisher icon derailed

feat(sort): allow sorting any column with top like navigation

Open ventsislav-georgiev opened this issue 1 year ago • 13 comments

Column Sorting Improvements: Added < (previous column), > (next column), and R (reverse order) key bindings for column sorting.

Key Binding Simplification: Removed redundant per-column sort key bindings and their hints across various resources, reducing clutter in keyspace.

Resolves: #1000

ventsislav-georgiev avatar Jun 15 '24 13:06 ventsislav-georgiev

@derailed Any feedback on this? Since this is a long standing issue with a previous PR, if the proposed implementation is bad in any way, please provide some insights on how we should go on implementing it. As it is really useful to be able to sort by any column quickly.

ventsislav-georgiev avatar Jun 26 '24 11:06 ventsislav-georgiev

@ventsislav-georgiev I think this feature is great. Let's resolve the conflict and I'll take a peek...

derailed avatar Aug 16 '24 00:08 derailed

@derailed Thanks, conflict resolved.

ventsislav-georgiev avatar Aug 20 '24 18:08 ventsislav-georgiev

ping @derailed

ventsislav-georgiev avatar Aug 23 '24 19:08 ventsislav-georgiev

@derailed Any chance we could merge this?

ventsislav-georgiev avatar Dec 07 '24 05:12 ventsislav-georgiev

@ventsislav-georgiev Looks like we have conflicts. Can you take a peek?

derailed avatar Feb 16 '25 01:02 derailed

@derailed rebased.

ventsislav-georgiev avatar Feb 16 '25 20:02 ventsislav-georgiev

@derailed rebased again.

ventsislav-georgiev avatar Apr 05 '25 08:04 ventsislav-georgiev

@derailed rebased yet again.

ventsislav-georgiev avatar Apr 11 '25 19:04 ventsislav-georgiev

@derailed Thank you for the review! I've made the requested changes. Removed all canned sorting keys. Now we only rely on <|>|R for sorting.

ventsislav-georgiev avatar May 18 '25 07:05 ventsislav-georgiev

ping @derailed

ventsislav-georgiev avatar May 24 '25 06:05 ventsislav-georgiev

ping @derailed

ventsislav-georgiev avatar Jun 04 '25 10:06 ventsislav-georgiev

This would make k9s so much better! Here's hoping it's getting merged and released soon.

spongebob-squarepants-is-sitting-at-a-table-in-a-restaurant-with-a-cup-of-coffee

mateipinzaru2 avatar Jun 18 '25 16:06 mateipinzaru2

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Jul 19 '25 02:07 github-actions[bot]

@derailed ping when you find time, so I can revive this. Let me know if you want to change it again somehow. Maybe the part about removing all canned sorting keys was too much?

ventsislav-georgiev avatar Oct 28 '25 09:10 ventsislav-georgiev